This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 0/4] Change 'len' of to_xfer_partial to ULONGEST


Hi,
This patch series is a preparation for the changes mentioned in the
discussion on changing target_ops method to_xfer_partial [1], in which,
the expected change would be

    LONGEST (*to_xfer_partial) (struct target_ops *ops,
				enum target_object object, const char *annex,
				gdb_byte *readbuf, const gdb_byte *writebuf,
				ULONGEST offset, LONGEST len);

to

    enum target_xfer_status (*to_xfer_partial) (struct target_ops *ops,
				enum target_object object, const char *annex,
				gdb_byte *readbuf, const gdb_byte *writebuf,
				ULONGEST offset, ULONGEST len, ULONGEST *xfered_len);

I started from the 'len' "LONGEST -> ULONGEST" transition, and that
is what this patch series tries to do.  This change is quite mechanical.
Regression tested on x86_64-linux with both native and gdbserver.  I
also rebuilt GDB in the following ways:

 - on x86-linux, with all targets enabled,
 - cross build native mingw32,mips-linux,hurd,sparc-linux, gdb on
   linux,
 - build native powerpc-linux gdb on gcc110
 - build spu-elf target on gcc110
 - build aix native gdb on gcc111
 - build native gdb for netbsd on gcc70

There are still some native targets uncovered, such as darwin, but it
should be easy to fix the build error.  Patch 2 is major part of this
series.  Patch 3 adjusts linux_common_xfer_osdata and patch 4 adjusts
two gdbarch methods.

I tried to turn -Wconversion on to help me to check some signed/unsigned
conversion, but it gives me thousands of errors in a clean build
(without my patches.  Looks signed/unsigned types are used freely in GDB
code base, so I didn't take much care of signed/unsigned conversion.

I'll finish the interface to_xfer_partial change in next step, and
adjust its implementations on some targets, such as tfile and ctf
targets.

[1] supporting all kinds of partially-<unavailable> enum target_object types
    https://sourceware.org/ml/gdb-patches/2013-10/msg00761.html

*** BLURB HERE ***

Yao Qi (4):
  Use target_xfer_partial_ftype for rs6000_xfer_shared_libraries
  Change to_xfer_partial 'len' type to ULONGEST.
  Change 'len' of linux_common_xfer_osdata to ULONGEST.
  Change 'len''s type from LONGEST to ULONGEST: gdbarch methods
    core_xfer_shared_libraries and core_xfer_shared_libraries_aix

 gdb/aix-thread.c          |    2 +-
 gdb/auxv.c                |   11 +++++++----
 gdb/bfd-target.c          |    2 +-
 gdb/bsd-kvm.c             |    2 +-
 gdb/bsd-uthread.c         |    2 +-
 gdb/common/linux-osdata.c |   22 +++++++++++-----------
 gdb/common/linux-osdata.h |    2 +-
 gdb/corelow.c             |    2 +-
 gdb/ctf.c                 |    2 +-
 gdb/darwin-nat.c          |   12 ++++++------
 gdb/exec.c                |    6 +++---
 gdb/exec.h                |    2 +-
 gdb/gdbarch.c             |    4 ++--
 gdb/gdbarch.h             |    8 ++++----
 gdb/gdbarch.sh            |    4 ++--
 gdb/gnu-nat.c             |    8 ++++----
 gdb/i386-cygwin-tdep.c    |    2 +-
 gdb/ia64-hpux-nat.c       |    6 +++---
 gdb/ia64-linux-nat.c      |    2 +-
 gdb/inf-ptrace.c          |    2 +-
 gdb/inf-ttrace.c          |    2 +-
 gdb/linux-nat.c           |   12 ++++++------
 gdb/monitor.c             |    4 ++--
 gdb/procfs.c              |    2 +-
 gdb/record-full.c         |    4 ++--
 gdb/remote-sim.c          |   13 +++++++------
 gdb/remote.c              |    2 +-
 gdb/rs6000-aix-tdep.c     |    4 ++--
 gdb/rs6000-aix-tdep.h     |    2 +-
 gdb/rs6000-nat.c          |    9 +++------
 gdb/sol-thread.c          |    2 +-
 gdb/sparc-nat.c           |    4 ++--
 gdb/spu-linux-nat.c       |    4 ++--
 gdb/spu-multiarch.c       |    2 +-
 gdb/target.c              |   16 ++++++++--------
 gdb/target.h              |    4 ++--
 gdb/tracepoint.c          |    2 +-
 gdb/windows-nat.c         |   10 +++++-----
 38 files changed, 101 insertions(+), 100 deletions(-)

-- 
1.7.7.6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]