This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Remove duplicated include in gdb directory
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Honggyu Kim <hong dot gyu dot kim at lge dot com>, gdb-patches at sourceware dot org
- Date: Mon, 06 Jan 2014 17:08:07 -0200
- Subject: Re: [PATCH v2] Remove duplicated include in gdb directory
- Authentication-results: sourceware.org; auth=none
- References: <1388973207-31270-1-git-send-email-hong dot gyu dot kim at lge dot com> <m3d2k56acm dot fsf at redhat dot com> <87a9f9oym6 dot fsf at fleche dot redhat dot com>
On Monday, January 06 2014, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> Thanks for the patch, Honggyu. I believe you have tested it by
> Sergio> building GDB with --enable-targets=all, right?
>
> That ordinarily would not be quite sufficient since this patch also
> touches *-nat parts. However, reading the patch I think it is obviously
> correct. None of the removed includes are "tricky" ones and the only
> odd case I saw (the osdata.c change) really is correct.
Thanks for pointing that out. I thought about the nat files, but then I
thought the change was obvious enough that it didn't request a deeper
test.
> Sergio> Other than that, let's wait for some maintainer to give the
> Sergio> green light.
>
> You have it.
Thanks, Tom.
Honggyu, could you please provide the ChangeLog for the patch? I can
push it to the repository when you do that.
Thanks,
--
Sergio