This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 6 Jan 2014 20:11:21 +0400
- Subject: Re: [PATCH] Cast to uintptr_t when calling ptrace32 on aix
- Authentication-results: sourceware.org; auth=none
- References: <1388821701-8011-1-git-send-email-yao at codesourcery dot com> <20140106155717 dot GB3802 at adacore dot com>
> > 2014-01-04 Yao Qi <yao@codesourcery.com>
> >
> > * aix-thread.c (pdc_read_regs): Cast parameter to uintptr_t
> > first.
> > (pdc_write_regs): Likewise.
> > (fetch_regs_kernel_thread): Likewise.
> > (store_regs_kernel_thread): Likewise.
>
> Thank you, Yao. I tested your patch with AdaCore's gdb testsuite,
> and found no regression.
>
> Some of the lines are now exceeding the hard limit (80 characters),
> and need to be folded. Apart from David's suggestion, which we can
> look at independently, the patch looks OK to me.
Actually, re-reading David's comments, I agree with him. Can we try
using a consistent approach? That would be an easy adaptation of your
patch, or mine, whichever you'd prefer. I don't really see the real
need for the second cast, so I'd lean towards adapting yours.
--
Joel