This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix copy of filename in bfd's filename field

From: nick clifton <nickc at redhat dot com>
To: Edjunior Barbosa Machado <emachado at linux dot vnet dot ibm dot com>, gdb-patches at sourceware dot org
Date: Fri, 03 Jan 2014 14:35:30 +0000
Subject: Re: [PATCH] Fix copy of filename in bfd's filename field
Authentication-results: sourceware.org; auth=none
References: <1388753936-2835-1-git-send-email-emachado at linux dot vnet dot ibm dot com>

Hi Edjunior,

gdb/
2014-01-03  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* gdb_bfd.c (gdb_bfd_stash_filename): Fix copy of filename in bfd's
	filename field using xstrdup.

@@ -69,7 +69,7 @@ gdb_bfd_stash_filename (struct bfd *abfd)
    strcpy (data, name);

    /* Unwarranted chumminess with BFD.  */
-  abfd->filename = data;
+  abfd->filename = xstrdup (data);
  }

  /* An object of this type is stored in each BFD's user data.  */


It might be nice to remove the comment too. :-)

Cheers
  Nick

Follow-Ups:
- Re: [PATCH] Fix copy of filename in bfd's filename field
  - From: Doug Evans

References:
- [PATCH] Fix copy of filename in bfd's filename field
  - From: Edjunior Barbosa Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]