This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 14/29] target: add ops parameter to to_prepare_to_store method
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Markus Metzger <markus dot t dot metzger at intel dot com>, jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org
- Date: Fri, 20 Dec 2013 17:23:34 +0000
- Subject: Re: [PATCH v9 14/29] target: add ops parameter to to_prepare_to_store method
- Authentication-results: sourceware.org; auth=none
- References: <1387471499-29444-1-git-send-email-markus dot t dot metzger at intel dot com> <1387471499-29444-15-git-send-email-markus dot t dot metzger at intel dot com> <52B33B4E dot 8070409 at redhat dot com> <87ioukk0io dot fsf at fleche dot redhat dot com>
On 12/19/2013 09:13 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> There are more sites that need updating. E.g., go32-nat.c,
> Pedro> nto-procfs.c, windows-nat.c, possibly others. Try grepping
> Pedro> for to_prepare_to_store.
> [...]
> Pedro> There should be a noprocess() call after the loop here.
>
> You can try this. I don't know whether it is complete but it's
> certainly more complete.
FAOD, it looks fine to me.
Thanks,
--
Pedro Alves