This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v9 29/29] record-btrace: add (reverse-)stepping support
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: jan dot kratochvil at redhat dot com, palves at redhat dot com, gdb-patches at sourceware dot org, Eli Zaretskii <eliz at gnu dot org>
- Date: Thu, 19 Dec 2013 20:10:06 +0000
- Subject: Re: [PATCH v9 29/29] record-btrace: add (reverse-)stepping support
- Authentication-results: sourceware.org; auth=none
- References: <1387471499-29444-1-git-send-email-markus dot t dot metzger at intel dot com> <1387471499-29444-30-git-send-email-markus dot t dot metzger at intel dot com>
On 12/19/2013 04:44 PM, Markus Metzger wrote:
> + if (non_stop)
> + error (_("Record btrace can't debug inferior in non-stop mode "
> + "(non-stop)."));
What's the intent of saying non-stop twice, in:
"in non-stop mode (non-stop)"
?
> + /* Stop all other threads. */
> + if (!non_stop)
> + ALL_THREADS (other)
> + other->btrace.flags &= ~BTHR_MOVE;
(I know it doesn't work currently), but in non-stop, the
event thread should also get its BTHR_MOVE flag cleared.
I didn't spot where that was being done.
> + /* GDB seems to need this. Without, a stale PC seems to be used resulting in
> + the current location to be displayed incorrectly. */
> + registers_changed_ptid (tp->ptid);
This really shouldn't be necessary, given target_resume does
it for you. If you still needed, you're papering over some
problem.
--
Pedro Alves