This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add target_xfer_partial_ftype
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Dec 2013 06:36:50 +0400
- Subject: Re: [PATCH] Add target_xfer_partial_ftype
- Authentication-results: sourceware.org; auth=none
- References: <1387286129-29463-1-git-send-email-yao at codesourcery dot com> <52B06BFD dot 7040809 at redhat dot com>
> > This patch adds a typedef target_xfer_partial_ftype. When we change
> > the signature of xfer_partial functions (for example, adding a new
> > parameter), we don't have to modify all of their declarations.
> >
> > This patch also updates the type of parameters of target_xfer_partial
> > from "void *" to "gdb_byte *".
> >
> > It is obvious to me, but comments are still welcome.
> >
>
> Thanks, looks good to me.
And FWIW, I really like it when we're using function types. These
types are also a good anchor for documenting their intended behavior.
--
Joel