This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet
- From: Doug Evans <xdje42 at gmail dot com>
- To: Hui Zhu <hui_zhu at mentor dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Sun, 8 Dec 2013 00:34:16 -0800
- Subject: Re: [PATCH] Let gdbserver doesn't tell GDB it support target-side breakpoint conditions and commands if it doesn't support 'Z' packet
- Authentication-results: sourceware.org; auth=none
- References: <5265022F dot 8060203 at mentor dot com> <52654A2C dot 9010202 at redhat dot com> <529707C7 dot 4040504 at mentor dot com> <5298AE7C dot 6020607 at redhat dot com> <529C80D2 dot 2080608 at mentor dot com> <529C9B42 dot 20600 at redhat dot com> <529D62F7 dot 80701 at mentor dot com> <52A22582 dot 8040509 at redhat dot com> <52A40015 dot 207 at mentor dot com>
On Sat, Dec 7, 2013 at 9:13 PM, Hui Zhu <hui_zhu@mentor.com> wrote:
> 2013-12-08 Hui Zhu <hui@codesourcery.com>
>
> PR gdb/16101
> * breakpoint.c (insert_bp_location): Change hw_bp_err_string to
> bp_err_string.
>
> Output error message of software breakpoints.
> Make solib error message output use same code with hardware
> breakpoints and software breakpoints.
>
> * remote.c (remote_insert_breakpoint): If this breakpoint has
> target-side commands but this stub doesn't support Z0 packets,
> throw error.
Nit. This changelog is badly formatted.
Please fix.
I suspect, though this is only based on perusal of the patch,
and not close analysis, that you meant to write:
PR gdb/16101
* breakpoint.c (insert_bp_location): Change hw_bp_err_string to
bp_err_string. Output error message of software breakpoints.
Make solib error message output use same code with hardware
breakpoints and software breakpoints.
* remote.c (remote_insert_breakpoint): If this breakpoint has
target-side commands but this stub doesn't support Z0 packets,
throw error.
[I may have gotten the indentation wrong, cut-n-paste in gmail, blech.
The point is the blank line before "Output error ..." is wrong. ISTM.]