This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] remove some sym_probe_fns methods
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 05 Dec 2013 21:06:44 -0200
- Subject: Re: [PATCH 2/4] remove some sym_probe_fns methods
- Authentication-results: sourceware.org; auth=none
- References: <1386100019-27379-1-git-send-email-tromey at redhat dot com> <1386100019-27379-3-git-send-email-tromey at redhat dot com>
On Tuesday, December 03 2013, Tom Tromey wrote:
> While looking into the probe API, it seemed to me that there were a
> number of methods in sym_probe_fns that were not needed. This patch
> removes them.
>
> Specifically, it seems to me that sym_probe_fns ought to be concerned
> with the API for constructing the probes. Any method relating to some
> aspect of an individual probe can be handled via the probe's own
> vtable. That is, the double indirection here doesn't seem useful --
> it certainly isn't in fact used, but also I couldn't think of a
> potential use.
This patch is great and needed, thanks a lot. The cleanup is more than
welcome.
I'll wait until you commit your patches so that I can rebase mine on top
of them.
Thanks,
--
Sergio