This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/commit+doco] GDB/MI: Document support for -exec-run --start in -list-features
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 03 Dec 2013 09:22:18 +0200
- Subject: Re: [RFA/commit+doco] GDB/MI: Document support for -exec-run --start in -list-features
- Authentication-results: sourceware.org; auth=none
- References: <1386051670-28637-1-git-send-email-brobecker at adacore dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Joel Brobecker <brobecker@adacore.com>
> Date: Tue, 3 Dec 2013 10:21:10 +0400
>
> While reviewing all the changes I made for GDB/MI, recently, and making
> sure that every new features should be check-able before use, I noticed
> that were were missing a way to test if --exec-run supports --start.
>
> This adds "exec-run-start-option" in the output of the -list-features
> commands, allowing front-ends to easily determine whether -exec-run
> supports the --start option.
>
> gdb/ChangeLog:
>
> * mi/mi-main.c (mi_cmd_list_features): add "exec-run-start-option".
> * NEWS: Expand the entry documenting the new -exec-run --start
> option to mention the corresponding new entry in the output of
> "-list-features".
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (GDB/MI Miscellaneous Commands): Document the new
> "exec-run-start-option" entry in the output of the "-list-features"
> command.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.mi/mi-start.exp: Add test verifying that -list-features
> contains "exec-run-start-option".
>
> Tested on x86_64-linux. Both code and doco parts are relatively
> straightforward, so I am planning on checking this in in a day or
> two, assuming doco approval.
You have my approval, with one comment: each one of the items in that
@table in gdb.texinfo should be indexed, to facilitate their
discoverability by readers. E.g., for this item I'd suggest
@findex exec-run-start-option
@cindex support for @option{--start} option in @code{-exec-run}
I'd also add an index entry for the entire section
@cindex supported @sc{gdb/mi} features, list
>From the past couple of weeks, it sounds like this section will grow
very fast (so maybe it should become a full-fledged @node).
Thanks.