This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR remote/15974
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 02 Dec 2013 10:02:40 +0000
- Subject: Re: [PATCH] Fix PR remote/15974
- Authentication-results: sourceware.org; auth=none
- References: <1385782688-375-1-git-send-email-yao at codesourcery dot com> <5299A894 dot 70100 at redhat dot com> <529C2B33 dot 20102 at codesourcery dot com>
On 12/02/2013 06:39 AM, Yao Qi wrote:
> On 11/30/2013 04:57 PM, Pedro Alves wrote:
>> Instead of setting and unsetting NC at each iteration, the "canonical" way
>> for this sort of thing is to check whether the loop ended:
>>
>> - if (nc == NULL)
>> + for (i == ARRAY_SIZE (notifs))
>>
>> And then again, we don't really need NC in the loop. I think
>> this would look cleaner and clearer:
>
> OK, you've fixed that bug :). Pushed it for you.
Thanks.
--
Pedro Alves