This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] fortran: enable ptype/whatis for user defined types.


>>>>> "Keven" == Keven Boell <keven.boell@intel.com> writes:

Keven>      /* Initialize this in case we *don't* use it in this call; that
Keven>         way we can refer to it unconditionally below.  */
Keven>      memset (&is_a_field_of_this, 0, sizeof (is_a_field_of_this));

I suspect this should be done inside the loop.

Keven> +    for (i = 0; i < sizeof(lookup_domains) / sizeof(lookup_domains[0]); ++i)

Spaces before "("s, but also you can use ARRAY_SIZE here instead.

Keven> +	sym = lookup_symbol (tmp, expression_context_block,
Keven> +			     lookup_domains[i],
Keven> +			     parse_language->la_language == language_cplus
Keven> +			     ? &is_a_field_of_this : NULL);

Not your problem, but checking for language_cplus here seems like old
copy-and-paste from the C++ parser.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]