This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] gdb: fix cygwin check in configure script


Pushed, thanks.

-- 
Pedro Alves

On 11/24/2013 12:13 PM, Steffen Sledz wrote:
> Avoids false positives if the search pattern "lose" is found in path
> descriptions in comments generated by the preprocessor.
> 
> see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
> 
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  gdb/ChangeLog    | 5 +++++
>  gdb/configure    | 2 +-
>  gdb/configure.ac | 2 +-
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index aec0768..ead7874 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-11-24  Steffen Sledz <sledz@dresearch-fe.de>
> +
> +	* configure: Rebuild.
> +	* configure.ac: fix cygwin detection check
> +
>  2013-11-24  Yao Qi  <yao@codesourcery.com>
>  
>  	* disasm.c (dis_asm_read_memory): Call target_read_code
> diff --git a/gdb/configure b/gdb/configure
> index 5514b2f..b38e183 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -12446,7 +12446,7 @@ lose
>  #endif
>  _ACEOF
>  if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
> -  $EGREP "lose" >/dev/null 2>&1; then :
> +  $EGREP "^lose$" >/dev/null 2>&1; then :
>    gdb_cv_os_cygwin=yes
>  else
>    gdb_cv_os_cygwin=no
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index 9b73887..2947293 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -1877,7 +1877,7 @@ AC_SUBST(WERROR_CFLAGS)
>  
>  # In the Cygwin environment, we need some additional flags.
>  AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin,
> -[AC_EGREP_CPP(lose, [
> +[AC_EGREP_CPP(^lose$, [
>  #if defined (__CYGWIN__) || defined (__CYGWIN32__)
>  lose
>  #endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]