This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at arm dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 26 Nov 2013 09:46:13 +0000
- Subject: Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
- Authentication-results: sourceware.org; auth=none
- References: <1385336092-19621-1-git-send-email-sergiodj at redhat dot com> <52931DB7 dot 6030205 at arm dot com> <m3y54cxk3s dot fsf at redhat dot com>
Hi
On 25 November 2013 21:11, Sergio Durigan Junior <sergiodj@redhat.com> wrote:
> I am not sure I completely understood your comment. Are you criticizing
> the shared asm parser for ARM targets only, or the generic asm parser in
> stap-probe.c? I assume it is the former. And I also fail to see why it
> can be considered coincidental cohesion... The shared parser covers one
> specific ARM assembly syntax, which is pretty similar to both 32- and
> 64-bit ARM.
> Correct me if I'm wrong, but you're actually against the way I've chosen
> to share the code between the targets, right? Or am I missing something
> here. If that's the case, I can try to come up with a simpler/cleaner
> way to share this code... Suggestions are appreciated, of course :-).
Sorry, I was not clear. I think the a64 and a32 parsers should be kept
separate rather than using a common parser for a different, but
similar syntax, thus avoiding the need to pass the flag that
distinguishes the different syntaxes.
Cheers
/Marcus