This is the mail archive of the
mailing list for the GDB project.
Re: Inconsistency between cli and python breakpoints for ignore count tracking
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 13 Nov 2013 09:59:00 +0000
- Subject: Re: Inconsistency between cli and python breakpoints for ignore count tracking
- Authentication-results: sourceware.org; auth=none
- References: <CAP9bCMSrU6kEheSYcOxJLt1W1Cgg1mt=yQDu9eXsGZxQiSpLcw at mail dot gmail dot com>
On 13/11/13 08:10, Doug Evans wrote:
> Does anyone have a reasonable explanation for why we do ignore_count
> tracking for python breakpoints (even with a "stop" method) but not
> for breakpoints that have a cli condition that doesn't trigger? The
> inconsistency doesn't feel right to me.
Me either, one branch is a bug.
I think we should discard ignore count tracking for Python breakpoints
that have a "stop" callback.
Because the "stop" callback is essentially "breakpoints with
conditions written in Python" I think we should never ignore the
return of that callback if the ignore count is not reached.
The goal of the "stop" callback is to allow much more complex
breakpoint conditions. The user has pretty much free reign to do
whatever they wish, or interrogate any inferior value they can access.
(They should not affect the state of the inferior, as documented).
Because the API is documented (and written) for the "stop" callback to
be authoritative, I we should adjust the Python logic to mimic the
"normal" conditions code.