This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: gdb.threads/*.exp failures
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 11 Nov 2013 07:40:54 -0700
- Subject: Re: gdb.threads/*.exp failures
- Authentication-results: sourceware.org; auth=none
- References: <CAP9bCMTPXLxetJ1z=9F_SZay2OCeoF7Ei8JsTTXrC5_TUFaorA at mail dot gmail dot com>
>>>>> "Doug" == Doug Evans <xdje42@gmail.com> writes:
Doug> I'm seeing several failures in gdb.threads/*.exp.
Doug> I traced this to HAVE_TKILL_SYSCALL being undefined in config.h,
Doug> and I traced that to syscall() no longer being checked for.
Here's the fix I am checking in.
Tom
commit 99c1d4518bf2ff230eaa6ee54c08e85f2d6c008e
Author: Tom Tromey <tromey@redhat.com>
Date: Mon Nov 11 07:35:57 2013 -0700
fix "tkill" check
An earlier patch removed the check for "syscall" since the results
were not used in the C code. However, the result was used, via the
cache variable, elsewhere in configure.
This patch fixes the problem by checking for "syscall" at the point at
which HAVE_TKILL_SYSCALL is defined.
2013-11-11 Tom Tromey <tromey@redhat.com>
* config.in, configure: Rebuild.
* configure.ac (HAVE_TKILL_SYSCALL): Check for "syscall".
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 34908ab..88db73a 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1736,8 +1736,10 @@ if test "x$ac_cv_header_sys_syscall_h" = "xyes"; then
)
fi
dnl See if we can issue tkill syscall.
-if test "x$gdb_cv_sys_syscall_h_has_tkill" = "xyes" && test "x$ac_cv_func_syscall" = "xyes"; then
- AC_DEFINE(HAVE_TKILL_SYSCALL, 1, [Define if you support the tkill syscall.])
+if test "x$gdb_cv_sys_syscall_h_has_tkill" = "xyes"; then
+ AC_CHECK_FUNC(syscall,
+ AC_DEFINE(HAVE_TKILL_SYSCALL, 1, [Define if you support the tkill syscall.])
+ )
fi
dnl Check if we can disable the virtual address space randomization.