This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c


>>>>> "Doug" == Doug Evans <dje@sebabeach.org> writes:

Doug> Tom Tromey <tromey@redhat.com> writes:
Stan> +/* A helper function for tyscm_richcompare that checks two types for
Stan> +   "deep" equality.  Returns non-zero if the types are considered the
Stan> +   same, zero otherwise.  */
>> 
Stan> "tyscm_richcompare"?  Should that be typy_... ?
>> 
>> It would be helpful if Doug could list all the change he made when
>> moving the code.

Doug> I don't understand.
Doug> Which changes?  While useful beyond its present state, this is in
Doug> essence just a cleanup.

I had thought this patch was more or less a straight move of the code.
But Stan's note revealed a change from what is currently in the tree.
So the question is, can you say what else changed?
That would be handy so I don't have to go over it line-by-line myself.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]