This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/6] introduce common.m4
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 05 Nov 2013 19:09:16 +0000
- Subject: Re: [PATCH v2 1/6] introduce common.m4
- Authentication-results: sourceware.org; auth=none
- References: <1383675811-3274-1-git-send-email-tromey at redhat dot com> <1383675811-3274-2-git-send-email-tromey at redhat dot com>
On 11/05/2013 06:23 PM, Tom Tromey wrote:
> 2013-11-04 Tom Tromey <tromey@redhat.com>
>
> * acinclude.m4: Include common.m4.
> * common/common.m4: New file.
> * configure, config.in: Rebuild.
> * configure.ac: Use GDB_AC_COMMON.
>
> 2013-11-04 Tom Tromey <tromey@redhat.com>
>
> * acinclude.m4: Include common.m4, codeset.m4.
HAVE_LANGINFO_CODESET is used by common/gdb_locale.h,
and GDB_AC_COMMON uses AM_LANGINFO_CODESET. Shouldn't
codeset.m4 then be included by common.m4 instead?
> * configure, config.in: Rebuild.
> * configure.ac: Use GDB_AC_COMMON.
(In cases like these, it's useful to include an indication
of which ChangeLog file each entry goes to. The above
is a case where that wasn't immediately obvious.)
--
Pedro Alves