This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve MI inferior output check / mi-console.exp

On 11/04/2013 04:41 AM, Luis Machado wrote:
>> > I don't think it does completely yet?  A check for the
>> > sim is missing.  We'd need:
>> >
>> >      [target_info protocol] == "sim"
>> >
>> > (see mi_gdb_target_load)
> Done.


> -		    -i $mi_inferior_spawn_id -re "$ipattern" {
> -			pass "$message inferior output"
> +		if { [target_info gdb_protocol] == "remote"
> +		    || [target_info gdb_protocol] == "extended-remote"
> +		    || [target_info gdb_protocol] == "sim"} {

That's not what I suggested, and I don't think it'd work
the same?

Looking around dejagnu, we see:

 /usr/share/dejagnu/config/sim.exp:136:set_board_info protocol  "sim"

And lots of boards load that config:

$ grep load_generic_config /usr/share/dejagnu/* -rn| grep sim
/usr/share/dejagnu/baseboards/m32r-linux-sim.exp:25:load_generic_config "sim"
/usr/share/dejagnu/baseboards/mips-sim.exp:22:load_generic_config "sim"
/usr/share/dejagnu/baseboards/mn10300-sim.exp:26:load_generic_config "sim"
/usr/share/dejagnu/baseboards/mips64-sim.exp:26:load_generic_config "sim"


  $ grep gdb_protocol /usr/share/dejagnu/* -rn| grep sim

comes out empty.

Otherwise looks OK.

Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]