This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb.dwarf2/dwzbuildid.exp: Avoid reserved variable name


On Fri, 1 Nov 2013, Tom Tromey wrote:

> Maciej> 	gdb/testsuite/
> Maciej> 	* gdb.dwarf2/dwzbuildid.exp: Rename `outdir' variable to 
> Maciej> 	`debugdir'.
> 
> Ok.

 Thanks for your review, I have applied the change now.

> I wonder whether we should mention it in banned_variables.

 Hmm, would it make sense to grep lib/*.exp for global variable references 
and see if there are any other candidates?

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]