This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 17/18] fix gdbarch buglet
- From: Pedro Alves <palves at redhat dot com>
- To: Ondrej Oprala <ooprala at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Mon, 21 Oct 2013 17:00:20 +0100
- Subject: Re: [PATCH 17/18] fix gdbarch buglet
- Authentication-results: sourceware.org; auth=none
- References: <1382369846-5817-1-git-send-email-ooprala at redhat dot com> <1382369846-5817-18-git-send-email-ooprala at redhat dot com>
It looks like the patch is about implicit int <-> enum
conversions, which a C++ compiler would complain about.
But the subject talks about a buglet -- what's the bug this
fixes?
Please always include a rationale for a change in the body
of the email.
On 10/21/2013 04:37 PM, Ondrej Oprala wrote:
> From: Tom Tromey <tromey@redhat.com>
>
> gdb/ChangeLog:
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
>
> * gdbarch.c: Regenerate.
> (byte_order_for_code): Likewise.
This "Likewise" doesn't make sense when you read this
entry sequentially (as one should and will).
> (gdbarch_byte_order): Change type of the return value.
> (gdbarch_byte_order_for_code): Likewise.
> * gdbarch.h: Regenerate.
> * gdbarch.sh (byte_order): Change the return type.
> (byte_order_for_code): Likewise.
--
Pedro Alves