This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] hardware watchpoints turned off, inferior not yet started
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: "Pedro Alves" <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 18 Oct 2013 16:43:38 +0100
- Subject: Re: [PATCH] hardware watchpoints turned off, inferior not yet started
- Authentication-results: sourceware.org; auth=none
- References: <525E5EB6 dot 4070305 at broadcom dot com> <525E8761 dot 8060405 at redhat dot com> <525EB424 dot 6010407 at broadcom dot com> <525EBEA7 dot 5060205 at redhat dot com> <5260FBE3 dot 8030200 at broadcom dot com> <52615305 dot 3050909 at redhat dot com>
On 18/10/2013 4:25 PM, Pedro Alves wrote:
> On 10/18/2013 10:14 AM, Andrew Burgess wrote:
>> After my patch then we do indeed see the error earlier, when the second
>> "file foo" is issued.
>
> BTW, not super important, but thinking out loud, I think it'd
> make sense to have the "set can-use-hw-watchpoints" command
> itself trigger a breakpoint/watchpoint reset.
I initially planned to do just this, but the manual says that after
a "set can-use-hw-breakpoints 0" previous breakpoints will remain
hardware while future ones will be software.
This clearly breaks a little (depending on interpretation) with
restarting the inferior / changing the file but we'd either need
to update the manual or carry additional information around on the
watchpoint to indicate if it's supposed to be HW/SW.
Thanks for taking the time to review my patch :)
Andrew