This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Disassembly readability (/r no spaces) [2]
- From: "Andrew Burgess" <aburgess at broadcom dot com>
- To: gdb-patches at sourceware dot org
- Cc: "Reini Urban" <reini at cpanel dot net>
- Date: Mon, 14 Oct 2013 10:39:46 +0100
- Subject: Re: [PATCH] Disassembly readability (/r no spaces) [2]
- Authentication-results: sourceware.org; auth=none
- References: <52582519 dot 3010105 at cpanel dot net> <52582EE7 dot 8050404 at cpanel dot net>
On 11/10/2013 6:01 PM, Reini Urban wrote:
> On 10/11/2013 11:19 AM, Reini Urban wrote:
>> Attached patch improves disassemble/r readability
>
>
> 2013-10-11 Reini Urban <rurban@cpanel.net>
>
> * disasm.c (dump_insns): Remove spacer = " "
> Align opcodes to max 10 byte insn
>
For x86 the current style, a space between every byte, matches the style
used by objdump, which might be the most familiar to users.
I think what we should really be doing is using the bytes_per_chunk
field of the disassemble_info structure in the same way objdump does so
we always group bytes in a similar way, matching the objdump style seems
like a good idea to me unless there's a compelling reason not to.
The aligning of instruction text does seem like a good idea though, and
would match the objdump behaviour.
Thanks,
Andrew