This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 16/18] fix up gdbtypes.h
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Ondrej Oprala <ooprala at redhat dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Sun, 13 Oct 2013 19:32:51 +0200
- Subject: Re: [PATCH 16/18] fix up gdbtypes.h
- Authentication-results: sourceware.org; auth=none
- References: <1381339053-14519-1-git-send-email-ooprala at redhat dot com> <1381339053-14519-17-git-send-email-ooprala at redhat dot com>
On Wed, 09 Oct 2013 19:17:31 +0200, Ondrej Oprala wrote:
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -17,6 +17,10 @@
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
>
> + * gdbtypes.h : Unbundle structures nested in union flds_bnds.
ChangeLogs should technically describe which struct moved where etc.
Such general description of the change is more appropriate as the optional
heading of the entry, therefore:
2013-10-09 Tom Tromey <tromey@redhat.com>
Unbundle structures nested in union flds_bnds.
* gdbtypes.h (union type_owner, union field_location, struct field)
(struct range_bounds): Moved out from ...
(struct main_type): ... here.
[ more structs here ]
> +
> +2013-10-09 Tom Tromey <tromey@redhat.com>
> +
> * common/vec.c (vec_p_preserve) : Add typedefs to struct vec_prefix *.
> * common/vec.h (VEC_OP) : Add typedefs to VEC(T).
>
[...]
OK with the patch itself; IIRC Tom said he did not modify anyhow the text
while moving it so I hope it is so.
Thanks,
Jan