This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/7] New lang-varobj.h

From: Yao Qi <yao at codesourcery dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Doug Evans <dje at google dot com>, <gdb-patches at sourceware dot org>
Date: Thu, 10 Oct 2013 07:50:11 +0800
Subject: Re: [PATCH 5/7] New lang-varobj.h
Authentication-results: sourceware.org; auth=none
References: <1379512482-31773-1-git-send-email-yao at codesourcery dot com> <1379512482-31773-6-git-send-email-yao at codesourcery dot com> <21068 dot 21875 dot 734416 dot 904684 at ruffy dot mtv dot corp dot google dot com> <20131008045901 dot GE3092 at adacore dot com>

On 10/08/2013 12:59 PM, Joel Brobecker wrote:

>How about move lang-varobj.h into varobj.h?

Not very important in the grand scheme of things, but I tend to agree
with the suggestion. If we had a lang-varobj.c, things might be
different. But for a simple definition of the language-specific ops
directly related to varobj, I'd keep things simple, inside varobj.h.


We don't have lang-varobj.c, but we'll have c-varobj.c, jv-varobj.c and

ada-varobj.c [done by patch 6/7]. Is it strong enough to justifycreating new file lang-varobj.h?


--
Yao (éå)

Follow-Ups:
- Re: [PATCH 5/7] New lang-varobj.h
  - From: Doug Evans

References:
- Re: [PATCH 5/7] New lang-varobj.h
  - From: Doug Evans
- Re: [PATCH 5/7] New lang-varobj.h
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]