This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 08 Oct 2013 13:44:33 -0600
- Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix
- Authentication-results: sourceware.org; auth=none
- References: <20131008183214 dot GB27355 at host2 dot jankratochvil dot net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I just noticed GDB does many needless double-opens with ENOENT like:
Whoops.
Jan> - if (result == NULL)
Jan> + if (result != NULL)
Jan> + fopen_e_ever_succeeded = 1;
Jan> + else if (!fopen_e_ever_succeeded)
What if we have it check for EINVAL instead?
Tom