This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7 V2] Trust readonly sections if target has memory protection
- From: Pedro Alves <palves at redhat dot com>
- To: "Abid, Hafiz" <Hafiz_Abid at mentor dot com>
- Cc: Stan Shebs <stanshebs at earthlink dot net>, "Mirza, Taimoor" <Taimoor_Mirza at mentor dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 08 Oct 2013 14:34:37 +0100
- Subject: Re: [PATCH 0/7 V2] Trust readonly sections if target has memory protection
- Authentication-results: sourceware.org; auth=none
- References: <1378432920-7731-1-git-send-email-yao at codesourcery dot com> <1378641807-24256-1-git-send-email-yao at codesourcery dot com> <201309091916 dot r89JGbpf009986 at glazunov dot sibelius dot xs4all dot nl> <522E9A8A dot 7040509 at codesourcery dot com> <52317B66 dot 3020602 at codesourcery dot com> <201309120949 dot r8C9nFsJ016506 at glazunov dot sibelius dot xs4all dot nl> <5232C9EC dot 2040707 at codesourcery dot com> <5249B9F9 dot 4030901 at redhat dot com> <5249BE1C dot 5050907 at redhat dot com> <525335C0 dot 8030004 at earthlink dot net> <5253F822 dot 2090707 at redhat dot com> <EB3B29AD43CA924DA27099BC85192376E06FF418 at EU-MBX-03 dot mgc dot mentorg dot com>
On 10/08/2013 01:47 PM, Abid, Hafiz wrote:
>> I distinctly remember reviewing this for the disassemble command, exactly
>> as I was suggesting. I now recall better because I also hacked on the patch
>> while iterating on multiple iterations of patch reviews. The change was
>> contained to just gdb/disasm.c (or the gross of it at least), IIRC.
>> Bleh, if we can't find it, we can always rewrite it. :-P.
>
> Taimoor wrote a patch about disassembly improvement in April 2011. Pedro review this patch but I think it stayed in our internal repo and never went upstream. If there is interest, I can try to resurrect it.
Ah! Thanks for digging that up. Yeah, that'd be great.
Thanks,
--
Pedro Alves