This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] testsuite/gdb.dwarf2: Enable dw2-error.exp tests for arm targets
- From: Tom Tromey <tromey at redhat dot com>
- To: "Abid\, Hafiz" <Hafiz_Abid at mentor dot com>
- Cc: Omair Javaid <omair dot javaid at linaro dot org>, "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Tue, 01 Oct 2013 09:20:01 -0600
- Subject: Re: [PATCH] testsuite/gdb.dwarf2: Enable dw2-error.exp tests for arm targets
- Authentication-results: sourceware.org; auth=none
- References: <CANW4E-2JhgU6rNJApL8g_yB1EWWMXKodsbbk9Pwt76e=SKGsMA at mail dot gmail dot com> <87li4y7f69 dot fsf at fleche dot redhat dot com> <CANW4E-18_+FikhAR0tfE7-1vNuMLCiQEybgsdJhZk-UHrW_-ng at mail dot gmail dot com> <87k3icsln0 dot fsf at fleche dot redhat dot com> <CANW4E-20eiPBPs-MfXRcDGRBV-KhS8AmRqCHOifnhJ3CdTyNFw at mail dot gmail dot com> <87k3i2ca3b dot fsf at fleche dot redhat dot com> <CANW4E-0OaKChjs7KswbgE6Nfyuwi41Gjvse3ccC6xaGOgKa2FQ at mail dot gmail dot com> <EB3B29AD43CA924DA27099BC85192376E06E8C1D at EU-MBX-02 dot mgc dot mentorg dot com>
>>>>> "Abid" == Abid, Hafiz <Hafiz_Abid@mentor.com> writes:
>> +if {[gdb_compile [list ${binfile}1.o ${binfile}2.o ] \
>> + "${binfile}" executable {}] != ""} {
>> + return -1
>> +}
>> +
>> +clean_restart ${testfile}
>> +
>> gdb_exit
>> gdb_start
>> gdb_reinitialize_dir $srcdir/$subdir
Abid> This gdb_exit, gdb_start, gdb_reinitialize_dir sequence right after
Abid> clean_restart tells me that perhaps one of them is redundant.
Good catch.
Given the rest of the test I think the clean_restart is not needed.
Tom