RE: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off" command.

["Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>]

I found out that this patch

$ cvs diff -up
cvs diff: Diffing .
Index: gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.246
diff -u -p -r1.246 gdb.exp
--- gdb.exp     20 Sep 2013 21:47:05 -0000      1.246
+++ gdb.exp     29 Sep 2013 22:50:10 -0000
@@ -1454,6 +1454,9 @@ proc default_gdb_start { } {
        perror "Spawning $GDB failed."
        return 1
     }
+    if [ishost "*-*-mingw*"] {
+       fconfigure $res -translation {crlf crlf}
+    }
     gdb_expect 360 {
        -re "\[\r\n\]$gdb_prompt $" {
            verbose "GDB initialized."


works... but only for cygwin dejagnu...

It doesn't on the dejagnu I found for msys system :(
After a looong debugging, it seems to turn out to be because

(on msys)$ runtest --version
WARNING: Couldn't find the global config file.
Expect version is       5.26
Tcl version is          8.4
Framework version is    1.4.2.x

while on cygwin:
$ runtest --version
Expect version is       5.45
Tcl version is          8.5
Framework version is    1.5

Which leads to the fact that remote_spawn directly calls spawn in 5.26,
while it uses open command in version 5.45...
The problem is that only the open command returns a channeled suitable for
fconfigure...
which leads to the following error on msys:

ERROR: tcl error sourcing ../../../puresrc/gdb/testsuite/gdb.base/co1.exp.
ERROR: can not find channel named "6"
    while executing
"fconfigure $res -translation {crlf crlf}"
    invoked from within
"if [ishost "*-*-mingw*"] {
        fconfigure $res -translation {crlf crlf}
    }"
    (procedure "default_gdb_start" line 37)
    invoked from within
"default_gdb_start"
    (procedure "gdb_start" line 2)
    invoked from within
"gdb_start"
    (procedure "clean_restart" line 7)
    invoked from within
"clean_restart $executable"
    (procedure "prepare_for_testing" line 6)
    invoked from within
"prepare_for_testing $testfile.exp $testfile  [list $srcfile $srcfile2] {debug n
owarnings}"
    (file "../../../puresrc/gdb/testsuite/gdb.base/co1.exp" line 1)
    ("uplevel" body line 1)
    invoked from within
"catch "uplevel #0 source $test_file_name""

Any suggestions, other that throwing away the old dejagnu ...
Of course, if someone as a more recent dejagnu for msys, 
I am all for it!


Pierre Muller

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyà : dimanche 29 septembre 2013 20:51
> Ã : Yao Qi
> Cc : Pierre Muller; 'Tom Tromey'; 'gdb-patches'
> Objet : Re: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off"
> command.
> 
> On 09/29/2013 02:44 PM, Yao Qi wrote:
> > On 09/28/2013 03:36 AM, Pedro Alves wrote:
> >> There was also a promising tcl/expect know that is supposed to
> >> disable the unnecessary \n -> \r\n translation...
> >
> > What is that?  Can you elaborate?
> >
> 
> https://sourceware.org/ml/gdb-patches/2013-09/msg00612.html
> 
> --
> Pedro Alves