This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Function is_elf_target.
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: nicolas dot blanc at intel dot com
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 27 Sep 2013 20:01:26 +0200 (CEST)
- Subject: Re: [PATCH] Function is_elf_target.
- Authentication-results: sourceware.org; auth=none
- References: <1380290903-28046-1-git-send-email-nicolas dot blanc at intel dot com>
> From: Nicolas Blanc <nicolas.blanc@intel.com>
> Date: Fri, 27 Sep 2013 16:08:23 +0200
>
> 2013-27-09 Nicolas Blanc <nicolas.blanc@intel.com>
>
> gdb/testsuite
> * lib/gdb.exp (is_elf_target): New function.
>
> Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
> ---
>
> Hi Mark,
>
> I am sending this patch in response to <http://sourceware.org/ml/gdb-patches/2013-09/msg00933.html>.
>
> Some reviewers prefer a white list whereas others prefer a black list. So it looks like the right approach is
> to compile a file and check if it is ELF.
>
> Please let me know if this change would be acceptable to you.
That's even better!
> gdb/testsuite/lib/gdb.exp | 39 +++++++++++++++++++++++++++++++++++++++
> 1 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 5e3331a..df83634 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -1796,6 +1796,45 @@ proc supports_reverse {} {
> return 0
> }
>
> +# Return 1 if target is ELF.
> +gdb_caching_proc is_elf_target {
> + set me "is_elf_target"
> +
> + set src [standard_temp_file is_elf_target[pid].c]
> + set obj [standard_temp_file is_elf_target[pid].o]
> +
> + set fp_src [open $src "w"]
> + puts $fp_src "int dummy () {return 0;}"
> + close $fp_src
> +
> + verbose "$me: compiling testfile $src" 2
> + set lines [gdb_compile $src $obj object {quiet}]
> +
> + file delete $src
> +
> + if ![string match "" $lines] then {
> + verbose "$me: testfile compilation failed, returning 0" 2
> + return 0
> + }
> +
> + set fp_obj [open $obj "r"]
> + fconfigure $fp_obj -translation binary
> + set data [read $fp_obj]
> + close $fp_obj
> +
> + file delete $obj
> +
> + set ELFMAG "\u007FELF"
> +
> + if {[string compare -length 4 $data $ELFMAG] != 0} {
> + verbose "$me: returning 0" 2
> + return 0
> + }
> +
> + verbose "$me: returning 1" 2
> + return 1
> +}
> +
> # Return 1 if target is ILP32.
> # This cannot be decided simply from looking at the target string,
> # as it might depend on externally passed compiler options like -m64.
> --
> 1.7.6.5
>
>