This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v15 4/5] Function is_known_elf_target.


> From: Nicolas Blanc <nicolas.blanc@intel.com>
> Date: Thu, 26 Sep 2013 19:05:25 +0200
> 
> 2013-17-07  Nicolas Blanc  <nicolas.blanc@intel.com>
> 
> gdb/testsuite
> 	* lib/gdb.exp (is_known_elf_target): New function.
> 
> Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>

My objection to this diff still stands.  The list is whoefully
incomplete.  Almost all new targets added to GDB in the past decade
have been ELF.  It makes much more sense to formulate this in terms of
a list of targets that are not ELF.

> ---
>  gdb/testsuite/lib/gdb.exp |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 5e3331a..93e48fe 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -1796,6 +1796,21 @@ proc supports_reverse {} {
>      return 0
>  }
>  
> +# Return 1 if target is known to support ELF.
> +proc is_known_elf_target {} {
> +
> +    if { [istarget "*-*-linux*"]
> +	 || [istarget "*-*-gnu*"]
> +	 || [istarget "*-*-elf*"]
> +	 || [istarget "arm*-*-eabi*"]
> +	 || [istarget "arm*-*-symbianelf*"]
> +	 || [istarget "powerpc-*-eabi*"] } {
> +	return 1
> +    }
> +
> +    return 0
> +}
> +
>  # Return 1 if target is ILP32.
>  # This cannot be decided simply from looking at the target string,
>  # as it might depend on externally passed compiler options like -m64.
> -- 
> 1.7.6.5
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]