This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Use AMD64_RX_REGNUM for X from 8 to 15 ind amd64*tdep.c sources
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: 'gdb-patches' <gdb-patches at sourceware dot org>
- Date: Wed, 25 Sep 2013 17:33:49 -0700
- Subject: Re: [RFA] Use AMD64_RX_REGNUM for X from 8 to 15 ind amd64*tdep.c sources
- Authentication-results: sourceware.org; auth=none
- References: <000001ceb580$51869960$f493cc20$ at muller@ics-cnrs.unistra.fr>
> 2013-09-19 Pierre Muller <muller@sourceware.org>
>
> Replace constant values 8 to 15 by AMD64_R8_REGNUM to
> AMD64_R15_REGNUM when a register index is expected.
> * amd64-windows-tdep.c (amd64_windows_dummy_call_integer_regs):
> Ditto.
> * amd64-tdep.c (amd64_dummy_call_integer_regs): Ditto.
> (amd64_dwarf_regmap): Ditto.
I think it's enough of a clear improvement that I can review
instead of asking MarkK to do it.
For the amd64-tdep.c portion, the recent patches moved the
amd64_dummy_call_integer_regs array back inside amd64_push_arguments,
named integer_regnum. You'll need to adjust the patch accordingly.
For the record, the amd64_windows_dummy_call_integer_regs
array had to be preserved, because it's shared between a coupe of
gdbarch methods.
So, patch pre-approved with the adjustment I mentioned in amd64-tdep.c.
Thank you, Pierre.
--
Joel