This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH V4 0/8] Intel(R) MPX register support
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: eliz at gnu dot org
- Cc: walfred dot tedeschi at intel dot com, gdb-patches at sourceware dot org
- Date: Wed, 25 Sep 2013 14:47:35 +0200 (CEST)
- Subject: Re: [PATCH V4 0/8] Intel(R) MPX register support
- Authentication-results: sourceware.org; auth=none
- References: <1378373188-31144-1-git-send-email-walfred dot tedeschi at intel dot com> <83y57bbo6q dot fsf at gnu dot org> <AC542571535E904D8E8ADAE745D60B191B18DB69 at IRSMSX104 dot ger dot corp dot intel dot com> <83vc2aj6qr dot fsf at gnu dot org> <AC542571535E904D8E8ADAE745D60B191B198F91 at IRSMSX104 dot ger dot corp dot intel dot com> <83eh8dgjxh dot fsf at gnu dot org>
> Date: Wed, 25 Sep 2013 15:33:30 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
> > CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> > Date: Wed, 25 Sep 2013 11:51:23 +0000
> >
> > Common code I meant the target dependent files, i.e. amd64-tdep.c and i386-tdep.c.
> >
> > We added code to support Linux only. Linux registers are processed at amd64-tdep-linux.c and i386-tdep-linux.c as well as amd64-linux-nat.c and i386-linux-nat.c.
> >
> > In order to implement the same features for windows we should have modified the amd64-tdep-windows and i386-tdep-windows.c and for Darwin amd64-tdep-darwin and i386-tdep-darwin.c for bsd there would be also some change on amd64bsd-native.c and i386bsd-native.c. Additionally we OS support that is still not ready on the other platforms.
> >
> > I hope to have clarified.
>
> I'm sorry to insist, but that's exactly my question: why were the
> changes done in Linux-specific i386-tdep-linux.c etc., and not in the
> CPU-specific i386-tdep.c etc.? These registers are specific to a CPU,
> not to an OS, aren't they?
Most of the changes are in i386-tdep.c and amd64-tdep.c. The bits
that are in *-linux-tdep.c are the bits to support core dumps, which
are OS-specific. Although some of those core dump bits might be more
generally useful. That's hard to judge though as long as Linux is the
only OS that actually has the necessary interfaces for exposing these
registers to the debugger.