This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] Fix Python 3 long/int logic error when converting a value in GDB
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Sep 2013 14:01:31 -0600
- Subject: Re: [patch][python] Fix Python 3 long/int logic error when converting a value in GDB
- Authentication-results: sourceware.org; auth=none
- References: <52396967 dot 50309 at redhat dot com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> I audited the code for other checks like this and found these files
Phil> use PyInt_Check.
Thank you.
Phil> Of those, the only check that makes a differentiation between a long
Phil> and an int is py-arch.c. The order for that check is already correct,
Phil> so no change is needed. The other files just do a simple number
Phil> check, and those work as intended.
Phil> OK?
I think that since the code is sensitive to the ordering, and since
we've already made an error here, it would be best to add an explanatory
comment at the two sites where it matters.
Tom