This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] New functions gdb_find_readelf, gdb_find_objcopy for testsuite
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Sep 2013 13:42:37 -0600
- Subject: Re: [patch] New functions gdb_find_readelf, gdb_find_objcopy for testsuite
- Authentication-results: sourceware.org; auth=none
- References: <yjt2li2vdv2j dot fsf at ruffy dot mtv dot corp dot google dot com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> [transform objcopy] and [transform readelf] aren't always sufficient
Doug> to find the right copy to use.
Doug> Akin to most other tools that have FOO_FOR_TARGET this patch
Doug> adds support for READELF_FOR_TARGET and OBJCOPY_FOR_TARGET.
Doug> Regression tested on amd64-linux.
Doug> I will commit this in a few days if there are no objections.
Seems reasonable to me.
Doug> +proc gdb_find_objcopy {} {
Doug> + global OBJCOPY_FOR_TARGET
Doug> + if [info exists OBJCOPY_FOR_TARGET] {
Normally I follow the C rule here about comments and newlines after
"declarations".
Tom