This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv3 1/5] Mostly code cleanup: Constification
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 18 Sep 2013 10:10:34 -0700
- Subject: Re: [patchv3 1/5] Mostly code cleanup: Constification
- Authentication-results: sourceware.org; auth=none
- References: <20130915193742 dot GA20411 at host2 dot jankratochvil dot net> <21047 dot 33940 dot 998451 dot 19883 at ruffy dot mtv dot corp dot google dot com> <20130918140806 dot GA9628 at host2 dot jankratochvil dot net>
On Wed, Sep 18, 2013 at 7:08 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> gdb/
> 2013-09-18 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Constification.
> * main.c (captured_main): Wrap symbol_file_add_main calls with
> TRY_CATCH. Twice.
> * symfile.c (symbol_file_add_main_1): Make args parameter const.
> (symbol_file_add): Make name parameter const.
> (symbol_file_add_main, symbol_file_add_main_1): Make args parameter const.
> (symfile_bfd_open): Make name parameter const, rename it to cname. Add
> variable name. Change their usage accordingly.
> * symfile.h (symbol_file_add, symfile_bfd_open): Make first parameter
> const.
> (symbol_file_add_main): Make args parameter const.
LGTM (modulo updating ChangeLog entry for captured_main).
thanks