This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR server/15959
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: "Agovic, Sanimir" <sanimir dot agovic at intel dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 17 Sep 2013 16:57:48 +0100
- Subject: Re: [PATCH] Fix PR server/15959
- Authentication-results: sourceware.org; auth=none
- References: <1379391203-14928-1-git-send-email-yao at codesourcery dot com> <0377C58828D86C4588AEEC42FC3B85A71767DCAA at IRSMSX105 dot ger dot corp dot intel dot com> <52381E7A dot 9000503 at codesourcery dot com>
Thanks Yao.
On 09/17/2013 10:18 AM, Yao Qi wrote:
> +static void
> +marker (void)
> +{}
> +
> +int
> +main(void)
Missing space after parens (you added it in "marker").
> +{
> + d = getenv("TEST");
Here too.
> +
> + marker ();
> +
> + return 0;
> +}
I think the test will fail on Windows, because there's no
"env" binary there. I think we should first try to see
if running "env" works, with "remote_exec target", and
mark the test UNSUPPORTED if it doesn't.
Otherwise it looks good to me.
--
Pedro Alves