This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[COMMITTED][RFC/TileGX 2/2] fix gdbserver runtime crash
- From: Jiong Wang <jiwang at tilera dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 17 Sep 2013 22:06:27 +0800
- Subject: [COMMITTED][RFC/TileGX 2/2] fix gdbserver runtime crash
- Authentication-results: sourceware.org; auth=none
- References: <50F9148F dot 3010602 at tilera dot com> <5237C847 dot 3040908 at tilera dot com> <5237CB65 dot 4000703 at tilera dot com> <20130917123304 dot GE3132 at adacore dot com> <52384D8E dot 4010009 at tilera dot com> <52385794 dot 1060307 at tilera dot com> <20130917132855 dot GF3132 at adacore dot com>
On 09/17/2013 09:28 PM, Joel Brobecker wrote:
it's a complicated story and my fault.
we use Perforce to manage code within the company. This bug is
fixed by Jeff (previous maintainer of TileGX gdb) long time ago in
Perforce, but he
didn't commit it to community. And we mainly test binaries
generated from our Perforce.
I should be more careful when I check dejagnu test result when
submit to community :)
No worries, here, just trying to understand the full story.
is this OK to commit?
Yes.
committed.
2013-09-16 Jiong Wang <jiwang@tilera.com>
* linux-tile-low.c (tile_regsets): Modify the size field to 64-bit
for each register.
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-tile-low.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- src/gdb/gdbserver/linux-tile-low.c 2013/06/07 10:46:59 1.4
+++ src/gdb/gdbserver/linux-tile-low.c 2013/09/17 14:00:30 1.5
@@ -124,7 +124,7 @@
static struct regset_info tile_regsets[] =
{
- { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
+ { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8,
GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
{ 0, 0, 0, -1, -1, NULL, NULL }
};
diff --git a/gdb/gdbserver/linux-tile-low.c
b/gdb/gdbserver/linux-tile-low.c
index 8963b9a..8efb34e 100644
--- a/gdb/gdbserver/linux-tile-low.c
+++ b/gdb/gdbserver/linux-tile-low.c
@@ -124,7 +124,7 @@ tile_store_gregset (struct regcache
*regcache, const void *buf)
static struct regset_info tile_regsets[] =
{
- { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 4,
+ { PTRACE_GETREGS, PTRACE_SETREGS, 0, tile_num_regs * 8,
GENERAL_REGS, tile_fill_gregset, tile_store_gregset },
{ 0, 0, 0, -1, -1, NULL, NULL }
};