This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/4] Match \r\r\n in testsuite
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 17 Sep 2013 06:35:30 -0700
- Subject: Re: [PATCH 0/4] Match \r\r\n in testsuite
- Authentication-results: sourceware.org; auth=none
- References: <87a9ldyu8k dot fsf at fleche dot redhat dot com> <1379423179-8515-1-git-send-email-yao at codesourcery dot com>
> Then, I restarted from the beginning again, and see if we can fix the
> problem by modifying testsuite. The requirement expressed in the
> previous patch review is that we should localize the changes to
> testsuite to match \r\r\n.
>
> This patch series is to change testsuite to match both \r\n and
> \r\r\n by modifying pattern to \r+\n in a localized manner. Patch 1/4
> is to replace gdb_test with gdb_test_sequence to match the output of
> "info tracepoints", so that the assumption of last character of each
> line is removed, so these patterns can be matched on all targets.
> Patch 2/4 is to transform \r\n in patterns to \r+\n, but \r\n in
> variables can't be transformed. Patch 3/4 transforms \r\n in variables.
How about we introduce a new official variable, similar to $hex,
$decimal, etc, which would correctly match new-line output based
on the host? I propose $eol, which is already used, but only in
2 testcases, so easy to adjust (remove "set eol ..." in those two
testcases).
--
Joel