This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patchv3 5/5] Support .dwp with the name of symlinked binary file


Jan Kratochvil writes:
 > Hi Doug,
 > 
 > fixing the .dwp symlinks issue is now easy.
 > 
 > 
 > Jan
 > 
 > 
 > gdb/
 > 2013-09-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
 > 
 > 	* dwarf2read.c (open_and_init_dwp_file): Try open_dwp_file also with
 > 	objfile->original_name.
 > 
 > gdb/testsuite/
 > 2013-09-15  Jan Kratochvil  <jan.kratochvil@redhat.com>
 > 
 > 	* gdb.base/dwp-symlink.c: New file.
 > 	* gdb.base/dwp-symlink.exp: New file.

Whether to put this testcase in gdb.base or gdb.dwarf2 is a toss up (IMO).
I'm happy with either, though other fission testcases are in gdb.dwarf2.
Just mentioning the possbility.

Otherwise, LGTM.
Thank you thank you thank you.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]