Re: Sim hangs on new target at dup_arg_p() in infinite loop.

[Mike Frysinger <vapier at gentoo dot org>]

On Monday 09 September 2013 16:13:38 Alexey Makhalov wrote:
> I've added checking for hash table overflow. It's better to have
> internal error message instead of looping.

please fix your mailer to send patches inline rather than base64 encoded.  it 
makes reviewing a lot easier when you do.

> --- sim/common/sim-options.c	3 Sep 2013 20:45:08 -0000	1.31
> +++ sim/common/sim-options.c	9 Sep 2013 20:12:25 -0000
>
> +	if (table_is_full++) {

GNU style says the brace goes on the following line.

> +          fprintf (stderr, "Internal error - number of options more than 
%d\n",

use sim_io_eprintf instead of fprintf

> +			  ARG_HASH_SIZE);
> +          abort ();
> +	}	
> +      }

also, i'm pretty sure the indentation style in your change is incorrect.  
please adjust to the GNU style.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.