This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset
- From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 11 Sep 2013 18:55:36 +0200
- Subject: Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset
- Authentication-results: sourceware.org; auth=none
- References: <877genmltz dot fsf at br87z6lw dot de dot ibm dot com> <87sixbfkb6 dot fsf at br87z6lw dot de dot ibm dot com> <83sixbiaqe dot fsf at gnu dot org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
>> Date: Wed, 11 Sep 2013 17:29:49 +0200
>>
>> --- gdb.orig/gdb/NEWS
>> +++ gdb/gdb/NEWS
>> @@ -111,6 +111,10 @@ show range-stepping
>> * GDB now understands the element 'tvar' in the XML traceframe info.
>> It has the id of the collected trace state variables.
>>
>> +* On S/390 targets that provide the transactional-execution feature,
>> + the program interruption transaction diagnostic block (TDB) is now
>> + represented as a number of additional "registers" in GDB.
>
> This part is OK, but the manual should cover this in more detail; I
> see no reference to "TDB" in your patch for the manual. So the reader
> of this NEWS entry will be unable to find any details about this new
> feature.
>
>> --- gdb.orig/gdb/doc/gdb.texinfo
>> +++ gdb/gdb/doc/gdb.texinfo
>
> This part is also OK, except for the above comment.
Good point. Do you think the following small addition would be
appropriate and sufficient?
--- a/gdb/gdb/doc/gdb.texinfo
+++ b/gdb/gdb/doc/gdb.texinfo
@@ -42683,7 +42683,9 @@
The @samp{org.gnu.gdb.s390.tdb} feature is optional. It should
contain the 64-bit registers @samp{tdb0}, @samp{tac}, @samp{tct},
-@samp{atia}, and @samp{tr0} through @samp{tr15}.
+@samp{atia}, and @samp{tr0} through @samp{tr15}. These ``registers''
+represent the appropriate fields in the program interruption
+transaction diagnostic block (TDB).
@node TIC6x Features
@subsection TMS320C6x Features
Diff finished. Wed Sep 11 16:49:47 2013