Re: [PATCH] Remove use of deprecated_init_ui_hook from quit_confirm.

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Fri, 6 Sep 2013 13:29:24 +0100
> From: "Andrew Burgess" <aburgess@broadcom.com>
> 
> There are only two places that deprecated_init_ui_hook is set
> (to !NULL) that I can find:
> 
>  1. In gdbtk, deprecated_init_ui_hook is used to grab a copy of
>     argv0, but is then immediately set back to NULL, and
> 
>  2. In windows-nat.c, deprecated_init_ui_hook is used to solve
>     an order of initialisation problem when creating a command
>     alias, in this case deprecated_init_ui_hook is left set.
> 
> In top.c:quit_confirm we check deprecated_init_ui_hook to detect if
> there's a GUI running.  For (1) above this will not kick in, but
> for (2) it does.... however... I don't see why this is a good thing,
> as I understand it the windows-nat.c code is not a GUI frontend for
> gdb, but is just "running-gdb-on-windows-hosts".  I find it hard to
> believe that the shorter, less informative, quit message is really
> desired... but maybe I've missed something.
> 
> The following patch removes the use of deprecated_init_ui_hook
> from quit_confirm, the only change I expect from this is that the
> quit message on windows hosts will fall into line with other hosts.

What situation would trigger the different quit message on Windows?
In GDB 7.6.1 built as MinGW native debugger for Windows, I only see
the "normal" quit message, viz.:

  (gdb) q
  A debugging session is active.

	  Inferior 1 [process 628] will be killed.

  Quit anyway? (y or n) y

So it looks like the allegedly Windows-specific quit message is never
used, although deprecated_init_ui_hook is non-NULL.  What am I
missing?

> OK to apply?

I'd suggest to wait until we fully understand the situation with this
hook.

Thanks.