Re: [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in windows_xfer_memory function

[Pedro Alves <palves at redhat dot com>]

On 09/01/2013 11:10 PM, Pierre Muller wrote:
> This is the patch that Pedro suggested I send
> after his commit to remove deprecated_xfer_memory
> in windows-nat.c.

Thanks.

> 
>   Pedro suggested that I submit this patch separately
> (which I do here)... and with a gdbserver counterpart,
> which I don't...
> 
>   I tried, but finally realized that given the
> read_memory / write_memory functions type defined
> in target.h target_ops structure,
> there is no way of passing information of partial 
> copy and of the length of this partial copy.
> Indeed, the comments state that the return value is either 0 for success
> or errno...
> 
> This is not compatible with returning information that only part of the
> request length
> was read/written.

Well, we could just change that interface to make it possible...

The thing I don't like with doing this only on the native
side, is that we're trying to get to a point where we
can share the target backends between GDB and gdbserver:

<https://sourceware.org/gdb/wiki/LocalRemoteFeatureParity>.

Doing such a change on the GDB side only just means we're
pushing the feature-parity goal for the Windows port
further away...

> 2013-09-01  Pierre Muller  <muller@sourceware.org>
> 
...
> 	Handle ERROR_PARTIAL_COPY error code.
...

This part is OK too.  (Please commit it separately from the
plongest fix.)

-- 
Pedro Alves