This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7] Intel(R) MPX registers support.
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: walfred dot tedeschi at intel dot com
- Cc: tromey at redhat dot com, jan dot kratochvil at redhat dot com, mark dot kettenis at xs4all dot nl, gdb-patches at sourceware dot org, walfred dot tedeschi at intel dot com
- Date: Wed, 21 Aug 2013 16:33:36 +0200 (CEST)
- Subject: Re: [PATCH 0/7] Intel(R) MPX registers support.
- References: <1377089148-11844-1-git-send-email-walfred dot tedeschi at intel dot com>
> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Wed, 21 Aug 2013 14:45:41 +0200
>
> This patch series adds support for the Intel(R) Memory Protection Extension
> MPX registers. Native and remote debugging are covered by this patch.
>
> New registers are bound registers known as bnd register (bnd0...bnd3), a
> config register bndcfgu and a status register bndstatus. Bound registers
> store pointer bounds, i.e. bound limits of a pointer. Bndstatus and bndcfgu
> store information of the current status and configuration of other MPX
> counterparts. For more information [1][2].
>
> Design notes:
> Bound register are represented in hardware as two fields of 64bits each,
> both in 64bit and 32bit mode. The fields are lower bound and upper bound.
> Upper bound value is a complement of one value of the upper limiting
> address. To take this into account the bnd0...bnd3 are created as
> pseudo registers while the hardware values are stored on bnd0raw...bnd3raw.
>
> Ok to commit?
Hi Walfred,
I had a quick look at the diffs. Generally looks good. There is an
issue though with how you handled the Linux-specific "orig_[er]ax"
fake register in the GDB interal register mapping. Can you change
things such that it remains at the very hand of the internal register
file?
I may not be able to do a full review of the changes in the next 2.5
weeks. A friendly reminder somewhere after Sep 9 wouldn't hurt ;).
Cheers,
Mark