This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] ARM Linux support for `catch syscall'
- From: Doug Evans <dje at google dot com>
- To: Samuel Bronson <naesten at gmail dot com>
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Thu, 15 Aug 2013 13:05:00 -0700
- Subject: Re: [PATCH v2] ARM Linux support for `catch syscall'
- References: <E1V4dYl-0006Y8-79 at hydrogen> <E1V5M2g-0000rM-TJ at hydrogen> <m31u689gic dot fsf at redhat dot com> <CADPb22TUkiyHfATXzeVfB8LzjBOjtu6Ym5gWh3EOHKAX8VfFEA at mail dot gmail dot com> <E1V9fPE-00060l-WC at hydrogen>
On Wed, Jul 31, 2013 at 1:47 PM, Samuel Bronson <naesten@gmail.com> wrote:
> This time, it passes all the tests and comes with a nearly complete
> XML file (plus a script that can nearly regenerate the XML file).
>
> (I elected to leave out __ARM_NR_cmpxchg, since it has dire warnings
> to the effect that the only pieces of code that should be aware of it
> are the implementation and the __kuser_cmpxchg code in entry-armv.S.)
>
> gdb/
> 2013-08-14 Samuel Bronson <naesten@gmail.com>
>
> ARM Linux support for `catch syscall'.
> * syscalls/arm-linux.py: New file.
> * syscalls/arm-linux.xml: Likewise.
> * arm-linux-tdep.c (arm_linux_get_syscall_number): New function.
> (arm_linux_init_abi): Register the new function and syscall xml file.
> * data-directory/Makefile.in: Install the new syscall xml file.
> * NEWS: Brag about this.
>
> gdb/testsuite/
> 2013-08-14 Samuel Bronson <naesten@gmail.com>
>
> ARM Linux support for `catch syscall'.
> * gdb.base/catch-syscall.exp: Test this on ARM now.
> (fill_all_syscalls_numbers): ARM has close/chroot on 6/61, too.
Hi.
The patch is ok with me (but see beow).
[Do you have a copyright assignment on file?]
>From sergio's comments:
>> +print("""\
>> +<?xml version="1.0"?>
>> +<!-- Copyright (C) 2009-%s Free Software Foundation, Inc.
>
>The copyright year should be from 2013 to %s, I guess.
Yeah, I think so.