This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase
- From: Anton Blanchard <anton at samba dot org>
- To: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- Cc: emachado at linux dot vnet dot ibm dot com (Edjunior Barbosa Machado), gdb-patches at sourceware dot org, brobecker at adacore dot com, luis_gustavo at mentor dot com
- Date: Fri, 2 Aug 2013 23:44:37 +1000
- Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase
- References: <20130731223046 dot 292f6a50 at kryten> <201308011554 dot r71Fs1r9008409 at d06av02 dot portsmouth dot uk dot ibm dot com>
Hi Uli,
> I think it might be best to just get rid of those .include statements;
> depending on an .inc file from another directory seems surprising.
>
> It seems you only need it for the gdbasm_declare macro; since this
> file is ppc64 specific anyway, why don't you just hard-code the
> .opd generation in this source file?
Considering the issues we have had with getting the correct include
paths passed into the assembler, I tend to agree. It only saves a couple
of lines.
> Also, the assembler source file probably ought to keep the
> copyright header. A comment why this test needs to use
> assembler source also would be good.
Thanks, will incorporate that into the next spin.
Anton