Re: [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the thread exit

[Yao Qi <yao at codesourcery dot com>]

On 07/29/2013 07:42 PM, Muhammad Waqas wrote:

Please have a look at 
http://sourceware.org/gdb/wiki/ContributionChecklist , it is very 
helpful for you to avoid some issues in your patch.

> 2013-07-24   Muhammad Waqas<mwaqas@codesourcery.com>
            ^^^ Two spaces.

>       PR gdb/11568
>       * breakpoint.c (breakpoint_auto_delete): add new condition
>       Remove thread related breakpoints if threads are exited.
^^^^^^^ Tab instead of spaces.

The changelog entry is like this:

	PR gdb/11568
	* breakpoint.c (breakpoint_auto_delete): Remove thread related
	breakpoints if threads are exited.

> Index: ./gdb/breakpoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/breakpoint.c,v
> retrieving revision 1.772
> diff -u -p -r1.772 breakpoint.c
> --- ./gdb/breakpoint.c    6 Jul 2013 07:14:54 -0000    1.772
> +++ ./gdb/breakpoint.c    29 Jul 2013 11:22:05 -0000
> @@ -11910,6 +11910,15 @@ breakpoint_auto_delete (bpstat bs)
>      {
>        if (b->disposition == disp_del_at_next_stop)
>          delete_breakpoint (b);
> +    else if (b->thread > 0)  /* If breakpoint relates to user created
> +                thread Check if it's not alive then
> +                delete it*/

Please move the comments into the brackets below.  Period is missing in 
your comment, and we need two spaces after period at the end of comment.

> +      {
> +    struct thread_info * tp = find_thread_id (b->thread) ;

A blank line is needed here.  Indentation looks wrong here.

> +    if (tp != NULL && (tp->state == THREAD_EXITED
> +               || !target_thread_alive (tp->ptid)))
> +      delete_breakpoint (b);

and here.

> +      }
>      }
>    }

I run thread-specific-bp.exp in async/non-stop mode, and I get a fail. 
I am afraid your patch only works in all-stop mode.

> testsuite/Changlog
>
> 2013-07-29  Muhammad Waqas<mwaqas@codesourcery.com>
>           Jan Kratochvil<jan.kratochvil@redhat.com>
 ^^^^^^^^^^
Need a tab instead of spaces.  Please reference existing entries in 
ChangeLog to see how to list two authors.

>       * gdb.threads/thread-specific-bp.c: New file.
>       * gdb.threads/thread-specific-bp.exp: New file.

Please include these new added files into your patch, so that people can 
review them.  Here is an example 
(http://sourceware.org/ml/gdb-patches/2013-07/msg00671.html) I include 
new added file in the patch.  I use git, but you can get the similar 
patch in cvs.

> # Copyright (C) 1996-2013 Free Software Foundation, Inc.

It should be 2013 only.

>         gdb_test_multiple "info breakpoint" "get info" {
>         -re "(\[0-9\]+)(\[^\n\r\]*breakpoint\[^\n\r\]*main.*thread $thre)" {

I don't really understand this pattern.  Probably, we only want to match 
"thread $thre"

".*$gdb_prompt $" is missing at the end of the pattern.  Please add it.

>             fail "threaded breakpoint not deleted"
>         }
>         -re "(\[0-9\]+)(\[^\n\r\]*breakpoint\[^\n\r\]*main.*\n)" {
>                 pass "threaded breakpoint deleted"

fail/pass should be the same.

>         }
>     }

Something like this:

    set test "thread-specific breakpoint is deleted"
    gdb_test_multiple "info breakpoint" $test {
	-re "thread $thre.*$gdb_prompt $" {
	    fail $test
	}
	-re "$gdb_prompt $" {
	    pass $test
	}
    }

There are some trailing spaces in the test.  Please remove them.

--
Yao (éå)