This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Regression for implptr.exp and pieces.exp [Re: [COMMIT PATCH] value_bits_valid: Fix latent bug.]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Andrew Burgess <aburgess at broadcom dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 24 Jul 2013 22:10:17 +0200
- Subject: Re: Regression for implptr.exp and pieces.exp [Re: [COMMIT PATCH] value_bits_valid: Fix latent bug.]
- References: <20130704160927 dot 11801 dot 10290 dot stgit at brno dot lan> <51D6DB44 dot 1000609 at broadcom dot com> <51D6E0EB dot 3040006 at redhat dot com> <51D6E441 dot 4040709 at broadcom dot com> <51D70EBB dot 4050505 at redhat dot com> <51DA92D9 dot 8050408 at broadcom dot com> <20130709095442 dot GA20006 at host2 dot jankratochvil dot net> <51DC1B1A dot 5090203 at broadcom dot com>
On Tue, 09 Jul 2013 16:15:54 +0200, Andrew Burgess wrote:
> On 09/07/2013 10:54 AM, Jan Kratochvil wrote:
> > 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439 is the first bad commit
> > commit 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439
> > Author: aburgess <aburgess>
> > Date: Mon Jul 8 10:21:33 2013 +0000
> >
> > Fix bug in value_bits_valid.
> >
> > http://sourceware.org/ml/gdb-patches/2013-07/msg00174.html
> >
> > * value.c (value_bits_valid): If the value is not lval_computed
> > or has no check validity handler then the answer is the
> > optimized_out flag, otherwise defer to the handler.
> >
> > Running gdb/testsuite/gdb.dwarf2/implptr.exp ...
> > -PASS: gdb.dwarf2/implptr.exp: print j in implptr:bar
> > +FAIL: gdb.dwarf2/implptr.exp: print j in implptr:bar
> > -PASS: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo
> > +FAIL: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo
> >
> > Running gdb/testsuite/gdb.dwarf2/pieces.exp ...
> > -PASS: gdb.dwarf2/pieces.exp: print a.i in pieces:f3
> > -PASS: gdb.dwarf2/pieces.exp: print a.j in pieces:f3
> > -PASS: gdb.dwarf2/pieces.exp: set a.i in pieces:f3
> > -PASS: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3
> > +FAIL: gdb.dwarf2/pieces.exp: print a.i in pieces:f3
> > +FAIL: gdb.dwarf2/pieces.exp: print a.j in pieces:f3
> > +FAIL: gdb.dwarf2/pieces.exp: set a.i in pieces:f3
> > +FAIL: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3
>
> I've committed a patch to revert all the changes done by Pedro and
> myself to value_bits_valid,
Confirming the temporary regression has been fixed by:
commit 34b2792f3cdf8d24d665257b56c6c576a8dfa27c
Author: aburgess <aburgess>
Date: Tue Jul 9 14:11:53 2013 +0000
Revert recent changes to value_bits_valid.
http://sourceware.org/ml/gdb-patches/2013-07/msg00243.html
* value.c (value_bits_valid): Revert previous change, and change
by Pedro on 2013-07-04, due to regressions in
gdb.dwarf2/implptr.exp and gdb.dwarf2/pieces.exp.
Jan