This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] change missing DWO complaint to a warning
- From: Doug Evans <dje at google dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 24 Jul 2013 08:49:01 -0700
- Subject: [commit] change missing DWO complaint to a warning
Hi.
I have committed this.
Since this situation can happen due to pilot error a warning is better.
2013-07-24 Doug Evans <dje@google.com>
* dwarf2read.c (lookup_dwo_cutu): Change missing DWO complaint to
a warning.
Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.814
diff -u -p -r1.814 dwarf2read.c
--- dwarf2read.c 23 Jul 2013 06:56:53 -0000 1.814
+++ dwarf2read.c 24 Jul 2013 15:41:48 -0000
@@ -9783,12 +9783,13 @@ lookup_dwo_cutu (struct dwarf2_per_cu_da
kind, dwo_name, hex_string (signature));
}
- complaint (&symfile_complaints,
- _("Could not find DWO %s %s(%s) referenced by %s at offset 0x%x"
- " [in module %s]"),
- kind, dwo_name, hex_string (signature),
- this_unit->is_debug_types ? "TU" : "CU",
- this_unit->offset.sect_off, objfile->name);
+ /* This is a warning and not a complaint because it can be caused by
+ pilot error (e.g., user accidentally deleting the DWO). */
+ warning (_("Could not find DWO %s %s(%s) referenced by %s at offset 0x%x"
+ " [in module %s]"),
+ kind, dwo_name, hex_string (signature),
+ this_unit->is_debug_types ? "TU" : "CU",
+ this_unit->offset.sect_off, objfile->name);
return NULL;
}